dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1056031925
##########
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##########
@@ -193,9 +165,9 @@ List<SolrCore> getCores() {
* @return An unsorted list. This list is a new copy, it can be modified by
the caller (e.g. it
* can be sorted).
*/
- List<String> getLoadedCoreNames() {
+ public List<String> getLoadedCoreNames() {
synchronized (modifyLock) {
- return distinctSetsUnion(cores.keySet(),
getTransientCacheHandler().getLoadedCoreNames());
+ return new ArrayList<>(cores.keySet());
Review Comment:
These methods are documented to return mutable copies, not immutable ones.
If I recall, maybe there were some callers that sorted the result? I'd prefer
immutable... not sure if we should change the contract right now (in 9.x);
maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
