stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1051253089
##########
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##########
@@ -114,11 +94,8 @@ protected void close() {
synchronized (modifyLock) {
// make a copy of the cores then clear the map so the core isn't
handed out to a request
// again
- coreList.addAll(cores.values());
+ coreList.addAll(getCores());
Review Comment:
if this is already holding 'modifyLock' does it still need to call getCores
which also attempts to grab the lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
