dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1055728773
##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
<int name="connTimeout">${connTimeout:15000}</int>
</shardHandlerFactory>
- <transientCoreCacheFactory name="transientCoreCacheFactory"
class="TransientSolrCoreCacheFactoryDefault">
Review Comment:
TransientCoreCache was pluggable. I don't think this is the right pluggable
thing, so I removed its plug-ability. Instead, I think "SolrCores" is better
suited to be pluggable. In so doing, the default/base SolrCores doesn't have
to know about transient cores, and is thus simpler to understand for nearly
everyone. Businesses like my employer (in the definite minority) can deal with
it in a different way than previously.
You propose a CoreFactory? Today, cores are created in CoreContainer (as
you know, I'm sure). I'm trying to narrowly limit the scope of this PR to not
be noticed by code that doesn't care about transient cores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
