alessandrobenedetti commented on code in PR #1245:
URL: https://github.com/apache/solr/pull/1245#discussion_r1055615528
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -84,30 +84,20 @@ public Query parse() {
}
private Query getFilterQuery() throws SolrException {
- if (!isFilter()) {
+ boolean isSubQuery = recurseCount != 0;
+ if (!isFilter() && !isSubQuery) {
String[] filterQueries = req.getParams().getParams(CommonParams.FQ);
if (filterQueries != null && filterQueries.length != 0) {
- List<Query> filters;
-
try {
- filters = QueryUtils.parseFilterQueries(req, true);
- } catch (SyntaxError e) {
+ List<Query> filters = QueryUtils.parseFilterQueries(req, true);
Review Comment:
Ok, now I remember this bit, I was initially (and I am still) not a fan of
that boolean param (as I tend to forget what it means and the name also doesn't
help).
We discussed for a better name(we couldn't find) and the reason to put it
that was was because that piece of code was shared across various Solr parts
and other reviewers thought it was better to isolate it and move it to the
queryUtils.
Not sure of course, if it's still the best solution to be honest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
