alessandrobenedetti commented on code in PR #1245:
URL: https://github.com/apache/solr/pull/1245#discussion_r1055592648
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -84,30 +84,20 @@ public Query parse() {
}
private Query getFilterQuery() throws SolrException {
- if (!isFilter()) {
+ boolean isSubQuery = recurseCount != 0;
+ if (!isFilter() && !isSubQuery) {
String[] filterQueries = req.getParams().getParams(CommonParams.FQ);
if (filterQueries != null && filterQueries.length != 0) {
- List<Query> filters;
-
try {
- filters = QueryUtils.parseFilterQueries(req, true);
- } catch (SyntaxError e) {
+ List<Query> filters = QueryUtils.parseFilterQueries(req, true);
+ SolrIndexSearcher.ProcessedFilter processedFilter =
+ req.getSearcher().getProcessedFilter(filters);
+ return processedFilter.filter;
+ } catch (SyntaxError | IOException e) {
Review Comment:
Done, didn't notice in my original review of the code for 9.1 !
Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
