dsmiley commented on code in PR #1245:
URL: https://github.com/apache/solr/pull/1245#discussion_r1055598404
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -84,30 +84,20 @@ public Query parse() {
}
private Query getFilterQuery() throws SolrException {
- if (!isFilter()) {
+ boolean isSubQuery = recurseCount != 0;
+ if (!isFilter() && !isSubQuery) {
String[] filterQueries = req.getParams().getParams(CommonParams.FQ);
if (filterQueries != null && filterQueries.length != 0) {
- List<Query> filters;
-
try {
- filters = QueryUtils.parseFilterQueries(req, true);
- } catch (SyntaxError e) {
+ List<Query> filters = QueryUtils.parseFilterQueries(req, true);
Review Comment:
Boolean parameters are kind of sadly confusing in methods when it's not
obvious what it is in code review tools (because the method name isn't a hint
either). Here, it is "fixNegativeQueries". It should be rare to need to do
that. It's redundant/needless here because getProcessedFilter deals with the
matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
