eliaporciani commented on code in PR #872: URL: https://github.com/apache/solr/pull/872#discussion_r881328822
########## solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc: ########## @@ -109,20 +109,20 @@ and the hyper-parameter of the HNSW algorithm make sure you set this configurati Here's how `DenseVectorField` can be configured with the advanced codec hyper-parameters: [source,xml] -<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" similarityFunction="cosine" codecFormat="Lucene90HnswVectorsFormat" hnswMaxConnections="10" hnswBeamWidth="40"/> +<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" similarityFunction="cosine" codecFormat="Lucene91HnswVectorsFormat" hnswMaxConnections="10" hnswBeamWidth="40"/> <field name="vector" type="knn_vector" indexed="true" stored="true"/> `codecFormat`:: + [%autowidth,frame=none] |=== -|Optional |Default: `Lucene90HnswVectorsFormat` +|Optional |Default: `Lucene91HnswVectorsFormat` |=== + (advanced) Specifies the knn codec implementation to use + -Accepted values: `Lucene90HnswVectorsFormat`. +Accepted values: `Lucene91HnswVectorsFormat`. Review Comment: I agree to remove the possibility to use custom Codec and use the Lucene default. However, I think it is better to open a specific Jira issue for that. For this pull request, I reintroduced the possibility to configure Lucene90HnswVectorsFormat in addition to Lucene91HnswVectorsFormat and I updated the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
