mocobeta commented on code in PR #872:
URL: https://github.com/apache/solr/pull/872#discussion_r880299238


##########
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##########
@@ -109,20 +109,20 @@ and the hyper-parameter of the HNSW algorithm make sure 
you set this configurati
 Here's how `DenseVectorField` can be configured with the advanced codec 
hyper-parameters:
 
 [source,xml]
-<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" 
similarityFunction="cosine" codecFormat="Lucene90HnswVectorsFormat" 
hnswMaxConnections="10" hnswBeamWidth="40"/>
+<fieldType name="knn_vector" class="solr.DenseVectorField" vectorDimension="4" 
similarityFunction="cosine" codecFormat="Lucene91HnswVectorsFormat" 
hnswMaxConnections="10" hnswBeamWidth="40"/>
 <field name="vector" type="knn_vector" indexed="true" stored="true"/>
 
 `codecFormat`::
 +
 [%autowidth,frame=none]
 |===
-|Optional |Default: `Lucene90HnswVectorsFormat`
+|Optional |Default: `Lucene91HnswVectorsFormat`
 |===
 +
 (advanced) Specifies the knn codec implementation to use
 +
 
-Accepted values: `Lucene90HnswVectorsFormat`.
+Accepted values: `Lucene91HnswVectorsFormat`.

Review Comment:
   I manually checked that Lucene 9.1.0 reads the vector index created by 
Lucene 9.0 (with `lucene-backward-codecs` jar). Coming 9.2.0 reads the vectors 
written by 9.0 and 9.1 as well.
   We keep all codecs in the same and the previous major version in 
backward-codecs, there is no need to care about the file format backward 
compatibility in an older but same major version from the users' perspective 
(Solr maintainers would properly add the dependency on backward-codecs module).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to