alessandrobenedetti commented on code in PR #872:
URL: https://github.com/apache/solr/pull/872#discussion_r883488153


##########
solr/core/build.gradle:
##########
@@ -87,6 +87,7 @@ dependencies {
   runtimeOnly "org.apache.lucene:lucene-analysis-phonetic"
   runtimeOnly "org.apache.lucene:lucene-backward-codecs"
   implementation "org.apache.lucene:lucene-codecs"
+  implementation "org.apache.lucene:lucene-backward-codecs"

Review Comment:
   necessary?



##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -42,8 +43,9 @@
  * {@link org.apache.lucene.search.KnnVectorQuery} for more details. It 
supports a fixed cardinality
  * dimension for the vector and a fixed similarity function. The default 
similarity is
  * EUCLIDEAN_HNSW (L2). The default index codec format is specified in the 
Lucene Codec constructor.
- * For Lucene 9.0 e.g. See {@link 
org.apache.lucene.codecs.lucene90.Lucene90Codec} Currently only
- * {@link org.apache.lucene.codecs.lucene90.Lucene90HnswVectorsFormat} is 
supported for advanced
+ * For Lucene 9.0 e.g. See {@link 
org.apache.lucene.codecs.lucene91.Lucene91Codec} Currently {@link

Review Comment:
   Lucene 9.0 -> Lucene 9.1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to