uschindler commented on code in PR #872: URL: https://github.com/apache/solr/pull/872#discussion_r879282560
########## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ########## @@ -282,9 +282,9 @@ public VectorValues getVectorValues(String field) { } @Override - public TopDocs searchNearestVectors(String field, float[] target, int k, Bits acceptDocs) - throws IOException { - return null; // because not supported. Throw UOE? + public TopDocs searchNearestVectors( + String field, float[] target, int k, Bits acceptDocs, int visitedLimit) throws IOException { Review Comment: See the typical Lucene pattern, eg. BulkScorer: https://github.com/apache/lucene/blob/d5d6dc079395c47cd6d12dcce3bcfdd2c7d9dc63/lucene/core/src/java/org/apache/lucene/search/BulkScorer.java#L37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org