cpoerschke commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r805760965
##########
File path: solr/core/src/java/org/apache/solr/handler/SnapShooter.java
##########
@@ -272,9 +273,11 @@ public void createSnapAsync(final int numberToKeep,
Consumer<NamedList<?>> resul
solrCore.getDirectoryFactory().release(dir);
}
- details.add("fileCount", files.size());
+ details.add("fileCount", files.size()); // DEPRECATED: for removal,
replaced with indexFileCount
+ details.add("indexFileCount", files.size());
details.add("status", "success");
- details.add("snapshotCompletedAt", new Date().toString());//bad; should
be Instant.now().toString()
+ details.add("snapshotCompletedAt", Instant.now().toString()); //
DEPRECATED: for removal, replaced with endTime
+ details.add("endTime", Instant.now().toString());
Review comment:
Maybe have a local to ensure both timestamps are 100% identical and/or
indicate intended removal timeline in the comment e.g.
```suggestion
final String endTime = Instant.now();
details.add("snapshotCompletedAt", endTime); // DEPRECATED: for
removal in Solr 10, replaced with endTime
details.add("endTime", endTime);
```
##########
File path:
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
##########
@@ -104,6 +104,44 @@ All the usages are replaced by
BaseHttpSolrClient.RemoteSolrException and BaseHt
In previous versions there was a field returned in async backup status
responses, `Response`. This has now been renamed to `msg`, to better fit other
collections API responses.
The `response` field is now a map, containing information about the backup
(`startTime`, `indexSizeMB`, `indexFileCount`, etc.).
+* SOLR-15982: For collection's snapshot backup request responses additional
fields `indexVersion`, `indexFileCount`, etc. were added similar to incremental
backup request responses. Also, both snapshot and incremental backup request
responses will now contain `starTime` and `endTime`. Here is an example of how
collection's snapshot backup request responses will looks like:
+
+Incremental:
+
+```json
+"response": {
+ "collection": "techproducts",
+ "numShards": 2,
+ "backupId": 0,
+ "indexVersion": "9.0.0",
+ "startTime": "2022-02-11T17:20:44.157305500Z",
+ "indexFileCount": 22,
+ "uploadedIndexFileCount": 22,
+ "indexSizeMB": 0.007,
+ "uploadedIndexFileMB": 0.007,
+ "shardBackupIds": [
+ "md_shard2_0",
+ "md_shard1_0"
+ ],
+ "endTime": "2022-02-11T17:20:45.245534400Z"
+}
+```
+
+Snapshot:
+
+```json
+"response": {
+ "collection": "techproducts",
+ "numShards": 2,
+ "indexVersion": "9.0.0",
+ "startTime": "2022-02-11T17:19:33.271461700Z",
+ "indexFileCount": 22,
+ "endTime": "2022-02-11T17:19:34.363859100Z"
+}
+```
Review comment:
Suggest to omit the example here and to update and/or extend the "Output
Snippet" in
https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc#backup-status
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
