ijioio commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r805901949
##########
File path: solr/core/src/java/org/apache/solr/handler/SnapShooter.java
##########
@@ -272,9 +273,11 @@ public void createSnapAsync(final int numberToKeep,
Consumer<NamedList<?>> resul
solrCore.getDirectoryFactory().release(dir);
}
- details.add("fileCount", files.size());
+ details.add("fileCount", files.size()); // DEPRECATED: for removal,
replaced with indexFileCount
+ details.add("indexFileCount", files.size());
details.add("status", "success");
- details.add("snapshotCompletedAt", new Date().toString());//bad; should
be Instant.now().toString()
+ details.add("snapshotCompletedAt", Instant.now().toString()); //
DEPRECATED: for removal, replaced with endTime
+ details.add("endTime", Instant.now().toString());
Review comment:
> Maybe have a local to ensure both timestamps are 100% identical
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
