magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799882766
########## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ########## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException { // but the addition of setLiveDocs means we needed to add volatile to "liveDocs". BitDocSet docs = liveDocs; if (docs == null) { Review comment: You're right that this case kind of undermines (for this special case) the improvements you introduced with SOLR-15555 ... I'll see what I can do about that... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org