magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799556562
########## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ########## @@ -1299,6 +1302,41 @@ public DocList getDocList(Query query, List<Query> filterList, Sort lsort, int o public static final int GET_DOCLIST = 0x02; // get the documents actually returned in a response public static final int GET_SCORES = 0x01; + private static boolean isConstantScoreQuery(Query q) { + if (q instanceof BoostQuery) { + // ConstantScoreQueries are often (always?) wrapped in BoostQuery to assign specific score Review comment: Something to keep an eye out for; I applied a patch for #529 and this wrapping still seems to happen. I think this is a side-effect of the way "ConstantScoreQuery" gets specified in queries (`(clause)^=n`) where `n` is the constant score, which is applied via wrapping in a BoostQuery. In any event it doesn't look like that changes with #529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org