magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1030362953
@madrob thanks very much for the review! I believe I've addressed all the concerns you raised. The only one I feel certain might merit more attention is the question of MatchAllDocs special-case, which I've adapted to now not (ever?) hit the filterCache, in 1e6cfeffbabd400b37afe8af8c1bc29d45d8de79. That allowed to revert some of the test workarounds (including a preexisting workaround related to pure-negative filters). Keeping MatchAllDocs off the `filterCache` is I think more generally a Good Thing -- in fact the change addressed an [existing TODO comment](https://github.com/apache/solr/blob/cb2e58f6569704c45387a8d094625ba8e014776b/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L869). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
