risdenk commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1022521366
@dsmiley agree about trying to reduce dependencies, but at the same time `transitive=false` requires a whole bunch of knowledge about how the code is being used. I think it makes sense to remove `transitive=false` in as many cases as possible and not try to exclude in every little case of a jar not being used. I understand this is sensitive in "core", but once #324 is merged, I think it would make sense to remove `transitive=false`. I'm currently looking into this a bit more especially in the contrib/modules where a lot of the `transitive=false` means we have constraints in `versions.props` that we don't need to keep track of any more. I think overall it simplifies our dependency tracking story and makes it a lot easier to reason about what is going on. I also have a POC about moving to Hadoop shaded client to avoid a ton of the dependency nightmare that HDFS has been. This should also happen post moving HDFS support to contrib/module. The hadoop auth stuff can't easily use the shaded dependencies, but hadoop auth stuff in Solr is relatively contained compared to the HDFS dependencies. @dsmiley do you agree that once HDFS is a contrib/module - then don't need to worry as much about the exclusions? I'm perfectly ok waiting until PR #324 is merged to finish this clean up. I think that PR #324 is pretty close to mergable based on talking with @warperwolf - he had some improvements about test configs there, but I don't think we should keep kicking the can down the road on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
