madrob commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1021553232
@risdenk I get several failures when trying to build this - jar license
errors, and then also this one which is pretty weird from `ecjLint`:
```
import javax.xml.stream.XMLInputFactory;
^^^^^^^^^^^^^^^^
The package javax.xml.stream is accessible from more than one module:
<unnamed>, java.xml
```
I think the new dependencies are adding an additional xml library that
causes conflicts? Maybe we need excludes of some flavor.
I ran the tests, it looks like security manager is enabled by default, so
thankfully that bit is happy with your changes.
Manually reviewed the changes you made to our forked classes, comparing them
with current 3.3.1 released classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
