[ https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342095#comment-17342095 ]
Houston Putman commented on SOLR-15335: --------------------------------------- bq. Oh, hmmm i adid need to add some "import" statments to docker/build.gradle but those are definitely necessary Ahh ok, must just be an intelliJ thing. bq. Ok ... so this is a big deal. I think it would be a huge mistake to rename Dockerfile.local -> Dockerfile I understand why you have a hard stance here. Perfectly fine keeping it as Dockefile.local bq. FYI: I'm AFK friday, may not have much time to work on this next week, and AFK the week after that ... I'll have a patch ready by the end of the day. I'll leave it up for a few days if you have time to review, but will commit if not. > templated (header + body) approach for building Dockerfile.local + > Dockerfile.official w/common guts > ---------------------------------------------------------------------------------------------------- > > Key: SOLR-15335 > URL: https://issues.apache.org/jira/browse/SOLR-15335 > Project: Solr > Issue Type: Sub-task > Reporter: Chris M. Hostetter > Assignee: Chris M. Hostetter > Priority: Major > Attachments: SOLR-15335-no-custom-network.patch, SOLR-15335.patch, > SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, > SOLR-15335.patch > > > Goals: > * "generate" a Dockerfile.official at release time that will satisfy the > process/tooling of docker-library for 'official' docker images > ** use a templated approach to fill in things like version, sha512, and GPG > fingerprint > * ensure that the generated Dockerfile.official and the Dockerfile.local > included in solr.tgz are identical in terms of the "operational" aspects of a > Solr docker image (ie: what the disk layout looks like, and how it runs) > ** they should only differ in how they get the contents of a solr.tgz into > the docker image (and how much they trust it before unpacking it) > * minimize the amount of overhead needed to make changes that exist in in > both dockerfiles -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org