[
https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339762#comment-17339762
]
Houston Putman commented on SOLR-15335:
---------------------------------------
bq. not really familiar with network aliases but if it plays nicer with
buildkit then sure
I actually took away the network aliases, this is using the default networking.
Just adding an entry in the etchosts file of the builder. So it's really
lightweight!
bq. but if there is anything in the templates that you think shouldn't be
committed at all w/o changing then by all means let's fix it
Ok a few comments on the actual build stuff:
* I think the Dockerfile in the Solr package should be named Dockerfile, not
Dockerfile.local
* The "[ dfLocalDetails, dfOfficialDetails ].each{ details ->" section deserves
some more explanation in comments. Explaining the overall goal of the section,
and some detail within. Otherwise it's kind of hard to understand that's where
the dockerfiles are actually built, IMO.
* It'd be nice to have small section in docker/gradle-help.txt that explains
the few commands for testing/building the official image. And where you can
find the official dockerfile once it has been created. With the caveat, that
all users should be using the regular docker build. This is merely for testing
changes to the dockerfile and the release manager.
* Maybe it's after my patch, but there might be some unused imports at the top.
I think the rest is good. Seriously awesome effort Hoss, this works really
really well.
> templated (header + body) approach for building Dockerfile.local +
> Dockerfile.official w/common guts
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-15335
> URL: https://issues.apache.org/jira/browse/SOLR-15335
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15335-no-custom-network.patch, SOLR-15335.patch,
> SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch,
> SOLR-15335.patch
>
>
> Goals:
> * "generate" a Dockerfile.official at release time that will satisfy the
> process/tooling of docker-library for 'official' docker images
> ** use a templated approach to fill in things like version, sha512, and GPG
> fingerprint
> * ensure that the generated Dockerfile.official and the Dockerfile.local
> included in solr.tgz are identical in terms of the "operational" aspects of a
> Solr docker image (ie: what the disk layout looks like, and how it runs)
> ** they should only differ in how they get the contents of a solr.tgz into
> the docker image (and how much they trust it before unpacking it)
> * minimize the amount of overhead needed to make changes that exist in in
> both dockerfiles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
