2010YOUY01 commented on PR #560: URL: https://github.com/apache/sedona-db/pull/560#issuecomment-3840286245
> Thank you! > > This is great! My main remaining high-level comment is that I think we should just have the `geometry_columns` be a pure override and not attempt to merge anything. I think this is simpler but also potentially more useful (can be used as an escape hatch to read a wider variety of input that provides incomplete or incorrect information that is difficult to otherwise fix). > > Note that there is some minor overlap with #561 ...I'd prefer to merge your PR first and I can handle whatever merge conflict may arise. Thank you for the review — that makes sense. I’ve switched to pure override semantics. Just realized for geoparquets with incorrect/missing metadata, `sedonadb` is likely the tool to fix them, so we need full overwrites here. For safety, adding validation support can be a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
