2010YOUY01 commented on code in PR #560:
URL: https://github.com/apache/sedona-db/pull/560#discussion_r2758211385
##########
rust/sedona-geoparquet/src/lib.rs:
##########
@@ -20,3 +20,5 @@ mod metadata;
pub mod options;
pub mod provider;
mod writer;
+
+pub use metadata::{GeoParquetColumnEncoding, GeoParquetColumnMetadata};
Review Comment:
cleaned up in
[dd75822](https://github.com/apache/sedona-db/pull/560/commits/dd75822c1bf9e39c17e68ad3c2a70f8c19542acb)
##########
rust/sedona-geoparquet/src/provider.rs:
##########
@@ -185,13 +188,41 @@ impl GeoParquetReadOptions<'_> {
Ok(GeoParquetReadOptions {
inner: ParquetReadOptions::default(),
table_options: Some(options),
+ geometry_columns: None,
})
}
/// Get the table options
pub fn table_options(&self) -> Option<&HashMap<String, String>> {
self.table_options.as_ref()
}
+
+ /// Add geometry column metadata (JSON string) to apply during schema
resolution
+ /// See python `read_parquet(..)` comments for details.
+ ///
+ /// Errors if invalid json configuration string is provided.
Review Comment:
Updated in
[dd75822](https://github.com/apache/sedona-db/pull/560/commits/dd75822c1bf9e39c17e68ad3c2a70f8c19542acb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
