2010YOUY01 commented on code in PR #560:
URL: https://github.com/apache/sedona-db/pull/560#discussion_r2758209769
##########
rust/sedona-geoparquet/src/format.rs:
##########
Review Comment:
I think this should not be applicable after we change to the fully overwrite
semantics? This combining step is only merging `bbox` and geo types, and reject
any other conflicts, and the overwriting step has to be done separately.
##########
rust/sedona-geoparquet/src/format.rs:
##########
@@ -167,6 +279,9 @@ impl FileFormat for GeoParquetFormat {
self.inner().compression_type()
}
+ /// Infer schema from GeoParquet metadata, then optionally override it
using
+ /// user-provided geometry column options (see Python DataFrame API
+ /// `read_parquet(..)` `geometry_columns` for details).
Review Comment:
cleaned up in
[dd75822](https://github.com/apache/sedona-db/pull/560/commits/dd75822c1bf9e39c17e68ad3c2a70f8c19542acb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
