pwrliang commented on PR #310: URL: https://github.com/apache/sedona-db/pull/310#issuecomment-3568921749
> > > @pwrliang Thanks for opening this PR! As per our discussion, we could break down this large PR into smaller ones to make it manageable and reviewable. Ideally, (1)libgpuspatial (c++ and cuda) with tests (2) gpu spatial join module in rust (3) build pipelines and e2e tests. > > > Let me know if you can reduce this to only include (1) with the proper cleanup and apache license headers. We can continue (2) and (3) once this one merges. Thanks! > > > > > > @zhangfengcdt Hi Feng, I have changed this PR to only keep the libgpuspatial part according to your suggestions. Please take a look. > > @pwrliang Could you please take a look at the failing lints and tests in the ci? Thanks! @zhangfengcdt I have fixed the CI. It failed because the runner did not have NVIDIA drivers, and the tests need to link libcuda.so, which comes from the drivers. After installing them, it succeeded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
