pwrliang commented on PR #310: URL: https://github.com/apache/sedona-db/pull/310#issuecomment-3555477714
> This is amazing! It has been very cool to watch this project evolve over the last six months and I know this represents a huge amount of work. > > This is a large change and I wanted to leave a few high-level things to think about while you're polishing this up. > > * I see a bit of commented-out code in some of the files...feel free to file GitHub issues if that code represents a future piece of work that needs doing (and remove the commented-out code)! > * I see CUDA-specific tests, which are great! If there are portions of the code that aren't well-covered by tests we do need to add them (we can open follow-on issues and do this in follow-up PRs too) > * Because we're an Apache project we need the licensing and provenance of the files to be clear. I see some copyright notices from Nvidia...there's a place in LICENSE.md to acknowledge subdirectories where code was copied. We also need license headers on all the files (there's a script in scripts/ that can help do mass addition of the license header to a bunch of files at once). > * It looks like you've done a great job ensuring the casual contributor doesn't have to deal with the GPU build complexity using `default-members`. That was one of my initial concerns but it looks great so far. > > Give me a ping when you're ready for me to take a look! @paleolimbot Hi, Dewey, thanks for your attention. Currently, this PR has resolved the license issues, and can pass almost all of the jobs in the CI. I'd like to hear any suggestions from you. @zhangfengcdt has written the Rust part to hook up sedona-db to libgpuspatial, so the credits for building go to him. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
