pwrliang commented on code in PR #310: URL: https://github.com/apache/sedona-db/pull/310#discussion_r2583582296
########## c/sedona-libgpuspatial/libgpuspatial/test/geoarrow_geos/geoarrow_geos.c: ########## @@ -0,0 +1,1101 @@ + +#include <errno.h> Review Comment: I believe sedona-db does not use your https://github.com/geoarrow/geoarrow-c-geos I copy-paste this because I recall that the original code has a bug? https://github.com/geoarrow/geoarrow-c-geos/blob/33ad0ba21c76c09e9d72fc4e4ae0b9ff9da61848/src/geoarrow_geos/geoarrow_geos.c#L472 the offset variable is not used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
