haizhou-zhao commented on code in PR #2420:
URL: https://github.com/apache/sedona/pull/2420#discussion_r2452872125
##########
spark/common/src/main/scala/org/apache/sedona/sql/UDF/AbstractCatalog.scala:
##########
@@ -86,9 +87,20 @@ abstract class AbstractCatalog {
functionIdentifier,
expressionInfo,
functionBuilder)
+ FunctionRegistry.builtin.registerFunction(
+ functionIdentifier,
+ expressionInfo,
+ functionBuilder)
+ }
+ aggregateExpressions.foreach { f =>
+ sparkSession.udf.register(f.getClass.getSimpleName, functions.udaf(f))
+ FunctionRegistry.builtin.registerFunction(
Review Comment:
For folks in the industry who're using HiveMetastore, IcebergRestCatalog or
other table metastore options: might be a good idea to leave an option open for
them to register geospatial related udf with various metastore options if they
prefer to do things that way (i.e. one draw back I could think of with having
too many buildin func is it complicates the resolving path for every command,
whether or not they contain geospatial udf). Don't have to do this in this PR,
but might be great to have a tracking issue or TODO in some form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
