jiayuasu commented on code in PR #2420:
URL: https://github.com/apache/sedona/pull/2420#discussion_r2450358974


##########
spark/common/src/main/scala/org/apache/sedona/sql/UDF/AbstractCatalog.scala:
##########
@@ -86,6 +87,10 @@ abstract class AbstractCatalog {
         functionIdentifier,
         expressionInfo,
         functionBuilder)
+      FunctionRegistry.builtin.registerFunction(

Review Comment:
   Can you confirm if this gets each function registered twice? (once for temp 
function, one for built-in)?
   
   How about `aggregateExpressions?`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to