zhangfengcdt commented on code in PR #2420:
URL: https://github.com/apache/sedona/pull/2420#discussion_r2452258398


##########
spark/common/src/main/scala/org/apache/sedona/sql/UDF/AbstractCatalog.scala:
##########
@@ -86,6 +87,10 @@ abstract class AbstractCatalog {
         functionIdentifier,
         expressionInfo,
         functionBuilder)
+      FunctionRegistry.builtin.registerFunction(

Review Comment:
   It looks like we need to register to both the 
`sessionState.functionRegistry` and the buildin simple function registry. They 
server different purpose, and if we remove the first one, functions cannot be 
used any more.
   
   I have added the three aggregate functions to buildin registry as well and 
also new test on creating views on spatial aggregation queries.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to