dimas-b commented on code in PR #3960: URL: https://github.com/apache/polaris/pull/3960#discussion_r2907386737
########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DataSourceResolver.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.persistence.relational.jdbc; + +import java.util.Set; +import javax.sql.DataSource; + +/** + * Service to resolve the correct {@link DataSource} for a given realm and store + * type. + * This enables isolating different workloads (e.g., entity metadata vs metrics + * vs events) + * into different physical databases or connection pools. + */ +public interface DataSourceResolver { + + /** The type of store representing the workload pattern. */ + enum StoreType { + MAIN, + METRICS, + EVENTS + } + + /** + * Resolves the DataSource for a given realm and store type. + * + * @param realmId the realm identifier + * @param storeType the type of store (e.g., main, metrics, events) + * @return the resolved DataSource + */ + DataSource resolve(String realmId, StoreType storeType); Review Comment: I'm thinking that we may want to use `RealmContext` instead of `String` realm ID here... just to continue the pattern of using `RealmContext` in pluggable components... e.g. `RealmConfigurationSource` , `TokenBucketFactory`, etc. 🤔 ########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ########## @@ -71,14 +72,21 @@ public class JdbcMetaStoreManagerFactory implements MetaStoreManagerFactory { final Map<String, EntityCache> entityCacheMap = new HashMap<>(); final Map<String, Supplier<BasePersistence>> sessionSupplierMap = new HashMap<>(); - @Inject Clock clock; - @Inject PolarisDiagnostics diagnostics; - @Inject PolarisStorageIntegrationProvider storageIntegrationProvider; - @Inject Instance<DataSource> dataSource; - @Inject RelationalJdbcConfiguration relationalJdbcConfiguration; - @Inject RealmConfig realmConfig; - - protected JdbcMetaStoreManagerFactory() {} + @Inject + Clock clock; Review Comment: nit: I wonder if the Spotless is going to complain about this 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
