Subham-KRLX opened a new pull request, #3960: URL: https://github.com/apache/polaris/pull/3960
Introduces a [DataSourceResolver](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DataSourceResolver.java:30:0-53:1) interface to decouple DataSource selection from [JdbcMetaStoreManagerFactory](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:62:0-285:1), enabling per-realm and per-store-type routing (main, metrics, events). **Changes:** - New [DataSourceResolver](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DataSourceResolver.java:30:0-53:1) interface with [resolve(realmId, storeType)](cci:1://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DefaultDataSourceResolver.java:54:4-58:5) - [DefaultDataSourceResolver](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DefaultDataSourceResolver.java:42:0-66:1) — routes everything to the default DS (no behavior change) - [JdbcMetaStoreManagerFactory](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:62:0-285:1) now uses [DataSourceResolver](cci:2://file:///Users/subhamsangwan/polaris/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DataSourceResolver.java:30:0-53:1) instead of direct `Instance<DataSource>` This is the foundation for #3890. Named DS resolution and config properties will follow. Closes #3890 ## Checklist - [x] 🛡️ Don't disclose security issues! - [x] 🔗 Linked: Fixes #3890 - [ ] 🧪 Tests to be added in follow-up - [x] 💡 Added comments for complex logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
