Subham-KRLX commented on code in PR #3960: URL: https://github.com/apache/polaris/pull/3960#discussion_r2909076964
########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DataSourceResolver.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.persistence.relational.jdbc; + +import javax.sql.DataSource; +import org.apache.polaris.core.context.RealmContext; + +/** + * Service to resolve the correct {@link DataSource} for a given realm and store + * type. This enables + * isolating different workloads (e.g., entity metadata vs metrics vs events) + * into different + * physical databases or connection pools. + */ +public interface DataSourceResolver { + + /** The type of store representing the workload pattern. */ + enum StoreType { + METASTORE, + METRICS, + EVENTS + } + + /** + * Resolves the DataSource for a given realm and store type. + * + * @param realmContext the realm context + * @param storeType the type of store (e.g., main, metrics, events) + * @return the resolved DataSource + */ + DataSource resolve(RealmContext realmContext, StoreType storeType); Review Comment: @flyrain Could you clarify your concerns regarding StoreType? Are you suggesting a more extensible approach (e.g., String identifiers) or perhaps routing at a different layer? Happy to refine this to better fit the project's direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
