emkornfield commented on code in PR #572: URL: https://github.com/apache/parquet-format/pull/572#discussion_r3350749003
########## LogicalTypes.md: ########## @@ -219,15 +219,15 @@ scale stores the number of digits of that value that are to the right of the decimal point, and the precision stores the maximum number of digits supported in the unscaled value. -If not specified, the scale is 0. Scale must be zero or a positive integer less -than or equal to the precision. Precision is required and must be a non-zero positive Review Comment: I think it is still good to call out non-zero here even though it is repetive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
