emkornfield commented on code in PR #572: URL: https://github.com/apache/parquet-format/pull/572#discussion_r3350740409
########## Geospatial.md: ########## @@ -58,19 +58,19 @@ by [-90, 90]. ## Edge Interpolation Algorithm -An algorithm for interpolating edges, and is one of the following values: +An algorithm for interpolating edges. It is one of the following values: -* `spherical`: edges are interpolated as geodesics on a sphere. -* `vincenty`: [https://en.wikipedia.org/wiki/Vincenty%27s_formulae](https://en.wikipedia.org/wiki/Vincenty%27s_formulae) -* `thomas`: Thomas, Paul D. Spheroidal geodesics, reference systems, & local geometry. US Naval Oceanographic Office, 1970. -* `andoyer`: Thomas, Paul D. Mathematical models for navigation systems. US Naval Oceanographic Office, 1965. -* `karney`: [Karney, Charles FF. "Algorithms for geodesics." Journal of Geodesy 87 (2013): 43-55](https://link.springer.com/content/pdf/10.1007/s00190-012-0578-z.pdf), and [GeographicLib](https://geographiclib.sourceforge.io/) +* `SPHERICAL`: edges are interpolated as geodesics on a sphere. Review Comment: not clear if capitalization here. it seems like this is a substantive changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
