emkornfield commented on code in PR #572: URL: https://github.com/apache/parquet-format/pull/572#discussion_r3350704604
########## Encryption.md: ########## @@ -136,9 +136,9 @@ one IV is ever repeated, then the implementation may be vulnerable"*. *"Complian requirement is crucial to the security of GCM"*. The bulk of modules in a Parquet file are page headers and data pages. Therefore, one encryption -key shall not not be used for more than 2^31 (~2 billion) pages. In Parquet files encrypted with -multiple keys (footer and column keys), the constraint on the number of invocations is applied -to each key separately. +key shall not be used for more than 2^32 total module encryptions, as per the NIST specification. Review Comment: this seems like a substantive change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
