keuin commented on code in PR #3586:
URL: https://github.com/apache/parquet-java/pull/3586#discussion_r3320267055
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetWriter.java:
##########
@@ -858,4 +863,68 @@ public void testNoFlushAfterException() throws Exception {
FileSystem fs = file.getFileSystem(conf);
assertTrue(!fs.exists(file) || fs.getFileStatus(file).getLen() == 0);
}
+
+ @Test
+ public void testV2PageNullCountWithStatisticsDisabled() throws Exception {
+ // Regression test: when using PARQUET_2_0 with statistics disabled on a
nullable column,
+ // DataPageHeaderV2.num_nulls must still contain the correct null count
(not -1).
+ MessageType schema = Types.buildMessage()
+ .required(INT32)
+ .named("id")
+ .optional(BINARY)
+ .as(stringType())
+ .named("value")
+ .named("test_schema");
+
+ File file = temp.newFile();
+ temp.delete();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
