keuin commented on code in PR #3586:
URL: https://github.com/apache/parquet-java/pull/3586#discussion_r3320258614
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnValueCollector.java:
##########
@@ -45,6 +45,10 @@ class ColumnValueCollector {
private SizeStatistics.Builder sizeStatisticsBuilder;
private GeospatialStatistics.Builder geospatialStatisticsBuilder;
+ // track the required `num_nulls` field in DataPageHeaderV2
+ //
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift
+ private int nullCount;
Review Comment:
Yes, placing it inside ColumnWriterBase is the correct way. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
