keuin opened a new pull request, #3586: URL: https://github.com/apache/parquet-java/pull/3586
<!-- Thanks for opening a pull request! If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose and format pull request title as below: GH-${GITHUB_ISSUE_ID}: ${SUMMARY} or simply use the title below if it is a minor issue: MINOR: ${SUMMARY} --> ### Rationale for this change Fix the num_nulls field in DataPageHeaderV2, which will be unexpectedly set to -1 when statistics is disabled. ### What changes are included in this PR? Add a counter tracker in ColumnValueCollector, which is always enabled, to track required field num_nulls. ### Are these changes tested? Yes, tested. The test will fail before this fix, and will succeed with this fix. ### Are there any user-facing changes? No user-facing or API changes. <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. --> Closes #3585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
