rdblue commented on code in PR #3212:
URL: https://github.com/apache/parquet-java/pull/3212#discussion_r2085685727
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroConverters.java:
##########
@@ -339,4 +341,26 @@ public String convert(Binary binary) {
return stringifier.stringify(binary);
}
}
+
+ static final class FieldVariantConverter<T> extends VariantColumnConverter {
+ protected final ParentValueContainer parent;
+ private final Schema avroSchema;
+ private final GenericData model;
+
+ public FieldVariantConverter(
+ ParentValueContainer parent, GroupType schema, Schema avroSchema,
GenericData model) {
+ super(schema);
+ this.avroSchema = avroSchema;
+ this.model = model;
+ this.parent = parent;
+ }
+
+ @Override
+ public void addVariant(Binary value, Binary metadata) {
Review Comment:
Looks like this class needs to suppress the warning for an unchecked cast:
```java
@Override
@SuppressWarnings("unchecked")
public void addVariant(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]