rdblue commented on code in PR #3212:
URL: https://github.com/apache/parquet-java/pull/3212#discussion_r2085645182
##########
parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java:
##########
@@ -61,6 +61,14 @@ public Variant(ByteBuffer value, ByteBuffer metadata) {
}
}
+ public ByteBuffer getValueRawBytes() {
Review Comment:
I think this should have a different name. It is odd to return `ByteBuffer`
from a method referring to "bytes". What about `getValueBuffer` and
`getMetadataBuffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
