rdblue commented on code in PR #3212: URL: https://github.com/apache/parquet-java/pull/3212#discussion_r2085700609
########## parquet-variant/src/main/java/org/apache/parquet/variant/VariantColumnConverter.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.parquet.variant; + +import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY; + +import java.util.List; +import org.apache.parquet.io.api.Binary; +import org.apache.parquet.schema.GroupType; +import org.apache.parquet.schema.Type; + +/** + * Converter for shredded Variant values. Connectors should implement the addVariant method, similar to + * the add* methods on PrimitiveConverter. + */ +public abstract class VariantColumnConverter extends VariantElementConverter { Review Comment: It appears that this is the top-level Variant. I think that should be called out more clearly than just "VariantColumn". I see why that makes sense, but "column" is overloaded so we should have a name that signals to the reader a little more clearly. Using `VariantConverter` would make sense to me if it weren't already used for the interface. Maybe `VariantValueConverter` could be used for the interface instead since those are dealing specifically with values and this is both metadata and value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
