ConeyLiu commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1948487733
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1131,7 +1227,9 @@ public void writeDataPageV2(
* @param pageHeaderAAD pageHeader AAD
* @param sizeStatistics size statistics for the page
* @throws IOException if any I/O error occurs during writing the file
+ * @deprecated will be removed in 2.0.0. Use {@link
ParquetFileWriter#writeDataPageV2(int, int, int, BytesInput, BytesInput,
Encoding, BytesInput, boolean, int, Statistics, BlockCipher.Encryptor, byte[],
SizeStatistics)} instead
*/
+ @Deprecated
Review Comment:
Separating those methods from `ParquetFileWriter` class and reducing the
duplication between `ColumnChunkPageWriteStore` could help the maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
