ConeyLiu commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1946370039
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -2152,12 +2207,43 @@ public void writeDataPageV2Header(
dataEncoding,
rlByteLength,
dlByteLength,
- crc),
+ compressed),
to,
blockEncryptor,
pageHeaderAAD);
}
+ public void writeDataPageV2Header(
+ int uncompressedSize,
+ int compressedSize,
+ int valueCount,
+ int nullCount,
+ int rowCount,
+ org.apache.parquet.column.Encoding dataEncoding,
+ int rlByteLength,
+ int dlByteLength,
+ boolean compressed,
Review Comment:
@pitrou @wgtmac changed to an explicit parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
