wgtmac commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1946676732
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java:
##########
@@ -737,6 +737,7 @@ private void processChunk(
encryptColumn,
dataEncryptor,
dataPageAAD);
+ boolean compressed = compressor != null;
Review Comment:
Shouldn't we get it from `headerV2` to keep it unchanged?
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1131,7 +1227,9 @@ public void writeDataPageV2(
* @param pageHeaderAAD pageHeader AAD
* @param sizeStatistics size statistics for the page
* @throws IOException if any I/O error occurs during writing the file
+ * @deprecated will be removed in 2.0.0. Use {@link
ParquetFileWriter#writeDataPageV2(int, int, int, BytesInput, BytesInput,
Encoding, BytesInput, boolean, int, Statistics, BlockCipher.Encryptor, byte[],
SizeStatistics)} instead
*/
+ @Deprecated
Review Comment:
Not related to this PR: we have plenty of deprecated public methods with a
bunch of parameters like this. It takes pain for the downstream to migrate
after removing them in the 2.0.0 and still likely to be deprecated if we need a
new parameter next time. Should we change these into a `Builder` or a class
with many parameters so we won't break anything in the future? @gszadovszky
@Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
