ChenSammi commented on code in PR #7012:
URL: https://github.com/apache/ozone/pull/7012#discussion_r1699905016
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -162,7 +157,13 @@ public long persistPutBlock(KeyValueContainer container,
}
}
- db.getStore().putBlockByID(batch, incrementalEnabled, localID, data,
+ if (incrementalEnabled.get() && !VersionedDatanodeFeatures.isFinalized(
+ HDDSLayoutFeature.HBASE_SUPPORT)) {
Review Comment:
Agree. We should add the HDDSLayoutFeature.HBASE_SUPPORT check in
finalizeBlock too. Although there is check in OM, the check in DN is also
preferred. It's like the double insurance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
