ChenSammi commented on code in PR #7012:
URL: https://github.com/apache/ozone/pull/7012#discussion_r1699870501
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -162,7 +157,13 @@ public long persistPutBlock(KeyValueContainer container,
}
}
- db.getStore().putBlockByID(batch, incrementalEnabled, localID, data,
+ if (incrementalEnabled.get() && !VersionedDatanodeFeatures.isFinalized(
+ HDDSLayoutFeature.HBASE_SUPPORT)) {
+ LOG.warn("DataNode has not finalized upgrading to a version that " +
+ "supports incremental chunk list. Fallback to full chunk list");
+ incrementalEnabled.set(false);
Review Comment:
There is chance that if pubBlock is first called before
HDDSLayoutFeature.HBASE_SUPPORT is finalized, then incrementalEnabled will be
set as false. In this case, incrementalEnabled will not come back as "true"
without the DN restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
