ashishkumar50 commented on code in PR #7012:
URL: https://github.com/apache/ozone/pull/7012#discussion_r1699762060
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -162,7 +157,13 @@ public long persistPutBlock(KeyValueContainer container,
}
}
- db.getStore().putBlockByID(batch, incrementalEnabled, localID, data,
+ if (incrementalEnabled.get() && !VersionedDatanodeFeatures.isFinalized(
+ HDDSLayoutFeature.HBASE_SUPPORT)) {
Review Comment:
But since OM also checks upgrade finalize before and call will fail in OM
itself, So in this case client will not call DN and I think this check is not
required in DN in case of `finalizeBlock.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
