jojochuang commented on code in PR #6530:
URL: https://github.com/apache/ozone/pull/6530#discussion_r1583851920
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3InitiateMultipartUploadRequestWithFSO.java:
##########
@@ -98,8 +98,6 @@ public void testValidateAndUpdateCache() throws Exception {
assertTrue(
omKeyInfo.getLatestVersionLocations().isMultipartKey(),
"isMultipartKey is false!");
- assertEquals(fileName, omKeyInfo.getKeyName(),
Review Comment:
would fileName match omKeyInfo.getFileName() instead?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneClientMultipartUploadWithFSO.java:
##########
@@ -874,7 +873,6 @@ private String verifyUploadedPart(String uploadID, String
partName,
assertNotNull(omKeyInfo);
assertNotNull(omMultipartKeyInfo);
- assertEquals(OzoneFSUtils.getFileName(keyName), omKeyInfo.getKeyName());
Review Comment:
shall we verify keyName and omKeyInfo.getKeyName() are the same?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java:
##########
@@ -820,10 +820,6 @@ private void verifyKeyInOpenFileTable(Table<String,
OmKeyInfo> openFileTable,
} else {
OmKeyInfo omKeyInfo = openFileTable.get(dbOpenFileKey);
assertNotNull(omKeyInfo, "Table is empty!");
- // used startsWith because the key format is,
- // <parentID>/fileName/<clientID> and clientID is not visible.
- assertEquals(omKeyInfo.getKeyName(), fileName,
Review Comment:
shall we check that omKeyInfo.getFileName() is the same as fileName?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
