ChenSammi commented on code in PR #6530:
URL: https://github.com/apache/ozone/pull/6530#discussion_r1582614237
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java:
##########
@@ -472,15 +472,13 @@ public static void addDirectoryTableCacheEntries(
*/
public static void addOpenFileTableCacheEntry(
OMMetadataManager omMetadataManager, String dbOpenFileName,
- @Nullable OmKeyInfo omFileInfo, String fileName, long trxnLogIndex) {
+ @Nullable OmKeyInfo omFileInfo, String fileName, String keyName,
long trxnLogIndex) {
final Table<String, OmKeyInfo> table = omMetadataManager.getOpenKeyTable(
BucketLayout.FILE_SYSTEM_OPTIMIZED);
if (omFileInfo != null) {
- // New key format for the openFileTable.
- // For example, the user given key path is '/a/b/c/d/e/file1', then in DB
- // keyName field stores only the leaf node name, which is 'file1'.
- omFileInfo.setKeyName(fileName);
+ // Set keyName as fileName along with path
Review Comment:
Ashish, can you keep the most of original comments too? It's good to have
comments about that keyName is using the full key path, and fileName is using
the leaf node name, and why, for others to easily understand these codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
