ashishkumar50 commented on PR #6530: URL: https://github.com/apache/ozone/pull/6530#issuecomment-2082559304
> > @ChenSammi I have made the change and the tests are running. One point is for hsync keys keyArgs are formed based on fileTable and not openFileTable in openKeyCleanupService. So even though we change openFileTable keyName, it is unused. So to handle this either we need to update fileTable keyName as well but that seems more risky as old key and new key format will differ and may cause other issues. Or we can use openFileTable just for keyName(Again not efficient solution). That i have currently added in PR. > > @ashishkumar50 , Yes, change the fileTable keyName will introduce the incompatibility, an upgrade will be required. Change keyName in openFileTable is less risky. > > The current change overall looks good. The thing is missed. After keyName in openFileTable is changed, we need to change it back to leaf name in OMKeyCommitRequest#validateAndUpdateCache before add to cache and return with OMKeyCommitResponse. Could you add this part, and verify that the final keyInfo has the same leaf name in keyName and fileName field? In OMKeyCommitRequest after reading keyName from openKeyTable it overwrites with keyName which comes in client request. I have added a verification to ensure keyName and fileName are same after auto commit in fileTable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
