smengcl commented on PR #11656: URL: https://github.com/apache/ozone/pull/11656#issuecomment-6513370928
> Was it not an issue for IPv4? Or perhaps because we never used ip literals to test clusters before? It is not IPv6 specific. An IPv4 literal goes through the same code. It went unnoticed because our test clusters (compose, MiniOzoneCluster, acceptance) configure OM and SCM addresses by host name. For a configured name, `getHostName()` returns that name and does no lookup, so nothing changes. It only matters when the address is configured as an IP literal. Even then it often still works: if every host's reverse lookup returns the same name and that name resolves, the ring forms on the name instead of the literal, and nobody notices. It breaks when hosts get different names for the same IP (a short name from `/etc/hosts` on the node itself, an FQDN from DNS on the others), or when the name can't be used. In compose the name is `ozone-ha-scm1-1.ozone-ha_default`, and gRPC rejects it because of the underscore. We hit it first on IPv6 because there the literal is the natural choice: the IPv6 compose cluster uses static addresses and configures OM and SCM by literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
